-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link v3: Re-add PayWithLinkViewController #4165
base: master
Are you sure you want to change the base?
Conversation
2 builds increased size, 4 builds decreased size
StripeSize 1.0 (1)
|
Item | Install Size Change |
---|---|
Packed Asset | ⬆️ 3.0 kB |
DYLD.Exports | ⬆️ 31.6 kB |
Code Signature | ⬆️ 15.3 kB |
📝 stp_fpx_big_logo@3x.png | ⬆️ 12.3 kB |
External Methods | ⬆️ 11.3 kB |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 10.7 kB (-0.71%)
Total download size change: ⬇️ 2.7 kB (-0.61%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
StripeCore.ElementsSessionContext.value witness | ⬇️ -916 B |
🗑 StripeCore.ElementsSessionContext.PrefillDetails | ⬇️ -775 B |
🗑 StripeCore.ElementsSessionContext.IntentID | ⬇️ -577 B |
DYLD.Exports | ⬇️ -568 B |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 11.1 kB (-0.26%)
Total download size change: ⬇️ 5.2 kB (-0.4%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... | ⬇️ -1.7 kB |
🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
📝 StripeFinancialConnections.FinancialConnectionsAPIClient.linkAcco... | ⬆️ 956 B |
StripeCore.ElementsSessionContext.value witness | ⬇️ -916 B |
🗑 StripeUICore.AddressSpecProvider.AddressSpecProvider | ⬇️ -896 B |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 11.0 kB (-0.27%)
Total download size change: ⬇️ 2.9 kB (-0.26%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
📝 StripePayments.STPPaymentMethodParams.label | ⬆️ 1.2 kB |
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬇️ -1.2 kB |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 11.7 kB (-0.19%)
Total download size change: ⬇️ 4.2 kB (-0.22%)
Largest size changes
Item | Install Size Change |
---|---|
Localizable.strings | ⬇️ -4.1 kB |
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🗑 StripeCore.Locale.toLanguageTag | ⬇️ -1.4 kB |
📝 StripePayments.STPPaymentMethodParams.label | ⬆️ 1.2 kB |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 98.4 kB (0.94%)
Total download size change: ⬆️ 39.9 kB (1.13%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripePaymentSheet.EmbeddedFormViewController | ⬇️ -24.1 kB |
🗑 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬇️ -8.2 kB |
📝 StripePaymentSheet.CardSectionElement.init(collectName,defaultVal... | ⬆️ 8.0 kB |
📝 StripePaymentSheet.EmbeddedPaymentMethodsView.init(initialSelecti... | ⬆️ 7.6 kB |
🗑 StripePaymentSheet.EmbeddedPaymentMethodsView.init(initialSelecti... | ⬇️ -7.5 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
🚨 New dead code detected in this PR: LinkNoticeView.swift:56 warning: Initializer 'init(type:text:)' is unused
LinkPaymentMethodPicker.swift:34 warning: Parameter 'picker' is unused
LinkPaymentMethodPicker.swift:269 warning: Parameter 'animated' is unused
PayWithLinkViewController-BaseViewController.swift:93 warning: Parameter 'sender' is unused
PayWithLinkViewController-NewPaymentViewController.swift:294 warning: Parameter 'sender' is unused
PayWithLinkViewController-NewPaymentViewController.swift:320 warning: Function 'shouldOfferLinkSignup(_:)' is unused
PayWithLinkViewController-SignUpViewController.swift:217 warning: Parameter 'sender' is unused
PayWithLinkViewController-SignUpViewController.swift:245 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-SignUpViewController.swift:307 warning: Parameter 'legalTermsView' is unused
PayWithLinkViewController-SignUpViewModel.swift:11 warning: Imported module 'StripeCore' is unused
PayWithLinkViewController-SignUpViewModel.swift:18 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-SignUpViewModel.swift:136 warning: Property 'configuration' is assigned, but never used
PayWithLinkViewController-UpdatePaymentViewController.swift:26 warning: Property 'intent' is assigned, but never used
PayWithLinkViewController-WalletViewController.swift:259 warning: Parameter 'intent' is unused
PayWithLinkViewController-WalletViewController.swift:295 warning: Parameter 'sender' is unused
PayWithLinkViewController-WalletViewController.swift:401 warning: Parameter 'viewModel' is unused
PayWithLinkViewController-WalletViewController.swift:415 warning: Parameter 'picker' is unused
PayWithLinkViewController-WalletViewController.swift:537 warning: Parameter 'mandateView' is unused
PayWithLinkViewController-WalletViewModel.swift:14 warning: Parameter 'viewModel' is unused
PayWithLinkViewController.swift:13 warning: Imported module 'StripeUICore' is unused
PayWithLinkViewController.swift:280 warning: Parameter 'completion' is unused
LinkInstantDebitMandateView.swift:19 warning: Parameter 'mandateView' is unused
PayWithLinkController-New.swift:17 warning: Class 'PayWithNativeLinkController' is unused
PayWithLinkController-New.swift:72 warning: Extension 'PayWithNativeLinkController' is unused
PaymentSheet+PaymentMethodAvailability.swift:63 warning: Property 'supportedLinkPaymentMethods' is assigned, but never used
PaymentSheetConfiguration.swift:191 warning: Property 'linkPaymentMethodsOnly' is assigned, but never used Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
cf726ee
to
6529349
Compare
StripePaymentSheet- public var paymentMethodLayout: StripePaymentSheet.PaymentSheet.PaymentMethodLayout
- }
- public enum PaymentMethodLayout {
- case horizontal
- case vertical
- case automatic
- public static func == (a: StripePaymentSheet.PaymentSheet.PaymentMethodLayout, b: StripePaymentSheet.PaymentSheet.PaymentMethodLayout) -> Swift.Bool
- public func hash(into hasher: inout Swift.Hasher)
- public var hashValue: Swift.Int {
- get
- } If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
6529349
to
35541e9
Compare
b00afa9
to
9f7cc8d
Compare
Summary
Re-add the Pay With Link View Controller.
Motivation
Link v3
Testing
Resurrected existing VC tests
Changelog
None